Skip to content

Conversation

mikhail-klimko
Copy link
Collaborator

@mikhail-klimko mikhail-klimko commented May 6, 2025

What

Given the following values:

global:
  nodeSelector:
    some-key: some-value
    extra-key: extra-value
  tolerations:
    - key: some-key
      operator: Equal
      value: some-value
      effect: NoSchedule

subchart:
  nodeSelector:
    some-key: another-value
    key: value
  tolerations:
    - key: another-key
      operator: Equal
      value: another-value
      effect: NoSchedule

The subchart should have ONLY constraints from subchart values and NOT .Values.globals

      nodeSelector:
        key: value
        some-key: another-value
      tolerations:
        - effect: NoSchedule
          key: another-key
          operator: Equal
          value: another-value

Why

Notes

@mikhail-klimko mikhail-klimko changed the title feat: don't merge global constaints feat(cf-common): don't merge global constaints May 6, 2025
@github-actions github-actions bot added the tests label May 6, 2025
@mikhail-klimko mikhail-klimko marked this pull request as ready for review May 6, 2025 08:04
@mikhail-klimko mikhail-klimko requested a review from a team as a code owner May 6, 2025 08:04
@mikhail-klimko mikhail-klimko merged commit fe09bb5 into master May 6, 2025
14 checks passed
@mikhail-klimko mikhail-klimko deleted the feat/global-constraints branch May 6, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants